Skip to content

Use correct accuracy format in Load text tutorial (text.ipynb) #2167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

nio1814
Copy link
Contributor

@nio1814 nio1814 commented Dec 27, 2022

No description provided.

@github-actions
Copy link

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin patch-2

Copy link
Contributor

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but in the future please write more descriptive commit message and PR titles, not just "update ". When someone looks at the commit history, they need to understand from the first line of the commit what the commit is about.

See https://cbea.ms/git-commit/

@github-actions github-actions bot added the lgtm Community-added approval label Dec 28, 2022
@8bitmp3 8bitmp3 changed the title Update text.ipynb Use correct accuracy format in Load text tutorial (text.ipynb) Dec 28, 2022
@8bitmp3 8bitmp3 self-assigned this Dec 28, 2022
@8bitmp3
Copy link
Contributor

8bitmp3 commented Dec 28, 2022

Thanks @nio1814 and @mihaimaruseac 👍 🎉

@8bitmp3 8bitmp3 added the ready to pull Start merge process label Jan 3, 2023
@8bitmp3
Copy link
Contributor

8bitmp3 commented Jan 3, 2023

thanks again, happy new year @nio1814

@copybara-service copybara-service bot merged commit 6fcde3e into tensorflow:master Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Community-added approval ready to pull Start merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants