Skip to content

Simple audio tutorial: macOS fix, typo, do not mix label variables #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Dec 28, 2022

The tutorial outcome is currently confusing since the plot shows a totally different prediction than the speech file. In the graph, "go" is allegedly predicted:

Tutorial before

This fixes the bug by using the correct variable for plot labels.

Plus minor fixes (see commit message).

Not sure

@github-actions
Copy link

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin patch-1

@8bitmp3 8bitmp3 self-assigned this Dec 28, 2022
@8bitmp3
Copy link
Contributor

8bitmp3 commented Dec 28, 2022

Thanks @AndiDog

@8bitmp3 8bitmp3 added the review in progress Someone is actively reviewing this PR label Dec 28, 2022
Copy link
Member

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkDaoust MarkDaoust added ready to pull Start merge process and removed review in progress Someone is actively reviewing this PR labels Jan 12, 2023
@github-actions github-actions bot added the lgtm Community-added approval label Jan 12, 2023
@copybara-service copybara-service bot merged commit b1b3a67 into tensorflow:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Community-added approval ready to pull Start merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants