Skip to content

Fixing the broken link in tf_records.ipynb #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

tilakrayal
Copy link
Contributor

Replaced the broken link in tf_records.ipynb with the right link

@github-actions
Copy link

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin patch-10

Copy link
Contributor

@8bitmp3 8bitmp3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tilakrayal

The old link was for the R1 (TF1) doc, but it's now a 404. cc @MarkDaoust

@github-actions github-actions bot added the lgtm Community-added approval label Jan 20, 2023
@MarkDaoust
Copy link
Member

Hi, thanks for the PR.

This does fix the 404, but generally this old copy of the tf1 docs gets ~no traffic, so we don't really maintain them.

@8bitmp3 8bitmp3 added the ready to pull Start merge process label Jan 24, 2023
@copybara-service copybara-service bot merged commit e616392 into tensorflow:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Community-added approval ready to pull Start merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants