Skip to content

RU translation: /tutorials/keras/ #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Dec 14, 2018
Merged

RU translation: /tutorials/keras/ #219

merged 38 commits into from
Dec 14, 2018

Conversation

0101011
Copy link
Contributor

@0101011 0101011 commented Nov 23, 2018

  1. For convenience I've created a separate site/ru folder (site/ru/tutorials/keras/) for all translations to be committed there

  2. Feel free to change the structure as needed

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no CLA has not been signed label Nov 23, 2018
@0101011
Copy link
Contributor Author

0101011 commented Nov 23, 2018

Signed the CLA

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes CLA has been signed and removed cla: no CLA has not been signed labels Nov 23, 2018
@0101011 0101011 changed the title basic_classification.ipynb - RU translation RU - basic_classification.ipynb Nov 23, 2018
@0101011 0101011 changed the title RU - basic_classification.ipynb RU translation - basic_classification.ipynb Nov 23, 2018
@lamberta
Copy link
Member

Thanks, Andrew! That was quicker than I anticipated 😀
I'll need to have some process dicussions as well as find a reviewer, but this is a great start. I'm out of the office until next week but will follow up when I get back.

Just curious, how difficult was the translation process? I take it you were already familiar with Jupyter notebooks and TensorFlow? As we build out a community process, is this something you're interested in contributing to?

@0101011
Copy link
Contributor Author

0101011 commented Nov 23, 2018

Hi Billy,

  1. I am not an X-Man, but quite familiar with TensorFlow and Jupyter and eager to contribute more:
    Is there a path I should follow for translations (tutorial folder, what next?)

  2. Translation process is quite interesting tbh:
    I've got the image of 16-20 years-old student reading this tutorial and tried to use the best suited language to make it understandable.

  • But sure do find a reviewer: I would appreciate some feedback! :)

@0101011 0101011 changed the title RU translation - basic_classification.ipynb RU translation: /tutorials/keras/ Nov 25, 2018
I be able to proofread this doc in 18 hours: 
I would appreciate if anyone be able to get to it earlier and add some comments
@ezhulenev
Copy link
Member

@lamberta can we share a "style guide" we used for other translations? @0101011 we basically have a small guide with "common terminology" that should not be translated, my guess that 90% of it will be directly applicable to russian translation

@0101011
Copy link
Contributor Author

0101011 commented Dec 7, 2018

@lamberta @ezhulenev Style guides would be handy:

  1. Yesterday I had a random thought of adding bite-sized "cheat sheets" to docs and colabs for readers to catch up quickly

  2. Btw, cheat sheets are all the rage now :)

@lamberta
Copy link
Member

lamberta commented Dec 8, 2018

Thanks for your work on this guys, it's been a pretty educational experience :)

After talking with Eugene, it does seem like there are technical words in English that do not have a natural translation, and we suspect many of these words are common across many target languages (based on feedback from some Chinese reviewers, as well). We don't have a master cheat sheet of "do not translate" words, but I just created a wiki page so maybe we can start adding to that: https://github.com/tensorflow/docs/wiki/Translation-notes

Andrew, for the cheat sheets, do you mean like a glossary of translations for ML terms? That could be interesting. The Machine Learning Crash Course maintains an ML glossary, and even some translations, but it doesn't look like Russian is there.

@0101011
Copy link
Contributor Author

0101011 commented Dec 8, 2018

@lamberta

  1. The wiki guide for translation is great: we'll add the most arguable terms over the course of the next week

  2. Downside: I can't PR to wiki of TF/docs, so we will drop you a list here as it's done

  3. We can implement cheat sheets like this into docs and colabs as little snippets or blocks (think of college textbooks) with short explanations of newly meet words (can be done with vanilla markdown):

My guess it'd be quite nifty for Korean, Chinese, Russian and other major target languages (btw, I saw an Arabic ML community on Twitter, ages 19 - 27: we can reach out to them for translations too)

  1. Alternative is a separate glossary as ipynb doc, but I'll come back with a more practical example later

  2. Here's a cool wiki page to get a sense of the approximate number of words in languages and why sometimes it is a problem :)

@lamberta
Copy link
Member

Hi Andrew,
We recently updated the Keras regression tutorial. The format is mostly the same but the content has changed to make the problem a little more straightforward. Would you mind updating your translation to reflect the current tensorflow.org? This section should now be relatively stable.

Yes, feel free to add your list here and I can update that wiki page. I'm not sure if we're going to keep that, but it should do for now. I'd prefer we standardize around the MLCC glossary but it doesn't look like there's a Russian version :(

Hold off on the cheatsheets, it will be easier to maintain these translations if they follow the en/ versions.

Thanks!

@0101011
Copy link
Contributor Author

0101011 commented Dec 13, 2018

@lamberta agree, maintaining should be stable

Got some fixes coming in 10 hours, I’ll be back 👍

Copy link
Member

@lamberta lamberta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work, Andrew, thanks so much!
I'm going to merge this here, but we still have some infrastructure work to do before we can pull the notebook in, render it, then display on https://tensorflow.org/?hl=ru
I can ping this bug to let you know when we get that working, probably after the winter break.

I've created a docs@tensorflow.org list to start to organize some of the community a little. Still early days but hopefully this will be a better way for contributors to communicate instead of just PR comments ;)

Thanks!

@lamberta lamberta added the ready to pull Start merge process label Dec 14, 2018
@0101011
Copy link
Contributor Author

0101011 commented Dec 14, 2018

@lamberta Hi Billy,

  1. Sure, no rush: I’m planning to do some final proofreading tomorrow just in case

  2. I’ll subscribe to the mailing list in a minute to see how we can make use of it (discuss and developers lists are buzzing, so I guess that’ll work :)

Have a great weekend!

@tensorflow-copybara tensorflow-copybara merged commit 90a369e into tensorflow:master Dec 14, 2018
tensorflow-copybara pushed a commit that referenced this pull request Dec 14, 2018
PiperOrigin-RevId: 225601705
@lamberta
Copy link
Member

Sounds good. Feel free to create another pull request if you have more edits. Thanks!

@MarkDaoust MarkDaoust mentioned this pull request Dec 17, 2018
@lamberta lamberta added the translation Community-provided translation for certain languages label Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA has been signed ready to pull Start merge process translation Community-provided translation for certain languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants