Skip to content

Updated the old link to new link in validate_correctness.ipynb #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

tilakrayal
Copy link
Contributor

Updated the broken link for Reusing TF1.x checkpoints guide with correct link

@tilakrayal tilakrayal requested a review from a team as a code owner March 3, 2023 06:47
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin patch-15

@@ -1254,7 +1254,7 @@
"source": [
"## Step 3b or 4b (optional): Testing with pre-existing checkpoints\n",
"\n",
"After step 3 or step 4 above, it can be useful to run your numerical equivalence tests when starting from pre-existing name-based checkpoints if you have some. This can test both that your legacy checkpoint loading is working correctly and that the model itself is working right. The [Reusing TF1.x checkpoints guide](./reuse_checkpoints.ipynb) covers how to reuse your pre-existing TF1.x checkpoints and transfer them over to TF2 checkpoints.\n"
"After step 3 or step 4 above, it can be useful to run your numerical equivalence tests when starting from pre-existing name-based checkpoints if you have some. This can test both that your legacy checkpoint loading is working correctly and that the model itself is working right. The [Reusing TF1.x checkpoints guide](https://github.com/tensorflow/docs/blob/master/site/en/guide/migrate/migrating_checkpoints.ipynb) covers how to reuse your pre-existing TF1.x checkpoints and transfer them over to TF2 checkpoints.\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same in this PR - just change the broken part of the URL.

e.g. ./migrating_checkpoints.ipynb

@markmcd
Copy link
Member

markmcd commented Mar 3, 2023

Thanks for the fix - Please take a moment to read the section on links in the style guide.

@github-actions github-actions bot added the lgtm Community-added approval label Mar 27, 2023
@8bitmp3 8bitmp3 self-assigned this Apr 3, 2023
@8bitmp3 8bitmp3 added the ready to pull Start merge process label Apr 3, 2023
@copybara-service copybara-service bot merged commit 0cf3f33 into tensorflow:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Community-added approval ready to pull Start merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants