Fix incomplete comment #2232
Merged
Fix incomplete comment #2232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the suggestion in the comment above is used as-is, the runtime returns an error due to incompatible data types.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
PreviewPreview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.Format and styleUse the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:$ python3 -m pip install -U --user git+https://github.com/tensorflow/docsIf commits are added to the pull request, synchronize your local branch: git pull origin patch-1
|
markmcd
previously approved these changes
Jun 12, 2023
Co-authored-by: Mark McDonald <macd@google.com>
|
Thanks @markmcd ! It looks like the format error is not related to my change, though. Should I still patch that in this same PR? 
|
oic, no that's OK. I'll send a follow-up. |
markmcd
approved these changes
Jun 13, 2023
markmcd
added a commit
to markmcd/docs
that referenced
this pull request
Jun 13, 2023
In tensorflow#2232, the nbfmt check was failing, so I've run it over all guides.
QuantumShadow87-cloud
added a commit
to QuantumShadow87-cloud/docs
that referenced
this pull request
Jul 29, 2023
* Update bfloat16 support for Intel CPUs * Update basics.ipynb * Update macos brew installation instructions from build from source The command for installing brew for macos build instructions is outdated and returning 404 error. As suggested by @markmcd that we don't need to maintain brew installation instructions which may vary at times and we need to track it continuously. Hence I am proposing to remove the brew installation instructions as user can refer the attached link and can do on his own. Please review and confirm whether this is OK. Thanks! * Fixed the broken link in versions.md Fixed the broken link for Python in line 37 * Update link to model-card-toolkit docs Updates the link to model-card-toolkit docs as the default branch of the model-card-toolkit repo was changed to "main". * Update time_series.ipynb The description above the corrected code said that the `linear` model could be called with `wide_window`, but instead the `baseline` model was called. So I corrected it to call the `linear` model. The outputs are unchanged and match the description. * Add support for a `base_url` flag in `nblint` This will allow the tool to be used for non-TF.org sites. Written to support Py3.8, which IIUC is all we support right now. PiperOrigin-RevId: 534855223 * Add automatic version numbers for tensorflow_docs. And drop 3.8 from supported list. Tested: ``` Successfully installed tensorflow-docs-2023.5.24.56664 ``` PiperOrigin-RevId: 535095942 * Strip dict methods from subclass pages. This will clear a bunch of noise from pages like: https://developers.generativeai.google/api/python/google/generativeai/types/SafetySettingDict PiperOrigin-RevId: 535472732 * Use TF 2.10 for video classification tutorial PiperOrigin-RevId: 536575726 * Fix a minor typo in "Distributed Input" ipynb file. PiperOrigin-RevId: 536823382 * Typo: custom_layers.ipynb Keeping it uniform through the Docs. * Typo fix: video_classification.ipynb (tensorflow#2229) Keeping it uniform. * Update pip.md resolve issue tensorflow/tensorflow#60750 * Update pip.md * Typofix: text_generation.ipynb Ironic Automated typo cleanup doc has a typo mistake. * Update text_generation.ipynb * second person fix text_generation.ipynb * Typo fix: video_classification.ipynb Missed in my previous pull * nbft fix * in proper nbfmt * Update install and build from source instructions PiperOrigin-RevId: 537906012 * Update configure.py to set Clang as the compiler for Linux CPU build PiperOrigin-RevId: 537923719 * Automated rollback of commit ac84b12 PiperOrigin-RevId: 537944155 * Add an overview to the Keras dev guide. PiperOrigin-RevId: 538786307 * Update toc to include Keras overview. PiperOrigin-RevId: 539129610 * Fix incomplete comment (tensorflow#2232) * fix: incorrect comment If the suggestion in the comment above is used as-is, the runtime returns an error due to incompatible data types. * Update site/en/guide/tensor.ipynb Co-authored-by: Mark McDonald <macd@google.com> --------- Co-authored-by: Mark McDonald <macd@google.com> * Run `nbfmt` on guide notebooks In tensorflow#2232, the nbfmt check was failing, so I've run it over all guides. * Use 2nd-person language in dtensor guide * Automated rollback of commit 4db8e80 PiperOrigin-RevId: 540301729 * Update configure.py to set Clang as the compiler for Linux GPU build PiperOrigin-RevId: 540321339 * Fixed confusion matrix normalization issue. * Update note in transfer_learning.ipynb related to Model.fit Issue #60907 * Add predict. * Change layer.get_weights()[0] to layer.embeddings in the warmstart_embedding_matrix tutorial. This prevents an error when the vocab is large and the embedding tensor gets sharded. PiperOrigin-RevId: 542046545 * Update transfer_learning.ipynb * Added activation function and increased epochs Added non-linear ReLU activation function in order to make the network a non-linear function approximator which is usually a wanted property when using neural networks. The increase in epochs is necessary to see a significant difference between using an activation function and not using one. * 10s * 10s * 10s * Formatted changed notebook * Remove "attachments". * Simplify the TF core "Text" nav. PiperOrigin-RevId: 544191396 * Update M1 pip instructions. PiperOrigin-RevId: 544201548 * Update video_classification.ipynb You made a silly error. Fixed 'calculation' spelling. * Fix KerasNLP product name. PiperOrigin-RevId: 544446499 * Documentation update for readability Documentation update for readability. * Update cuDNN and CUDA details Update cuDNN and CUDA details to support latest tensorflow version (2.12) * Update CUDA Details Update cuDNN and CUDA details to support latest tensorflow version (2.12). Working Gist: https://colab.sandbox.google.com/gist/chunduriv/faf217520a36296d07729a25b69d48ea/simple_audio.ipynb#scrollTo=AJs7HHFmg1M9 * Update download links for TF 2.13 Update correct paths for Tensorflow 2.13 built wheels in documentation. * JAX2TF guide: minor style and grammar fixes * Add support for Python 3.10+ X | Y style unions. PiperOrigin-RevId: 547855197 * Remove CUDA/cuDNN installation instructions in Simple Audio tutorial * Fix json error. * Fix function.ipynb PiperOrigin-RevId: 547932510 * Fix typos and misleading GPU info in pip install instructions for MacOS. PiperOrigin-RevId: 547934602 * Update Warm-start Embedding Layer Matrix tutorial * Format Warm-start Embedding Layer Matrix tutorial * fix: inconsistent single host multi-device guide * Update site/en/guide/mixed_precision.ipynb include suggested changes Co-authored-by: Mark Daoust <markdaoust@google.com> * Update latest wheels Update TF 2.13 wheels * Move remaining text tutorials to text/ PiperOrigin-RevId: 551003625 * Update TF wheels to 2.13 * Fix a stray 2.11 * Clarify the tf.function tracing rules for custom classes PiperOrigin-RevId: 551287285 * Remove links to migrated text tutorials. We already have a link to the text subsite, so there's no longer a need to call out the migrated docs individually. PiperOrigin-RevId: 551590336 --------- Co-authored-by: Gauri1 Deshpande <gauri1.deshpande@intel.com> Co-authored-by: Sarvesh Kesharwani <sarveshkumar5513@gmail.com> Co-authored-by: SuryanarayanaY <116063290+SuryanarayanaY@users.noreply.github.com> Co-authored-by: Tirumalesh <111861663+tiruk007@users.noreply.github.com> Co-authored-by: Suzen Fylke <codesue@users.noreply.github.com> Co-authored-by: Salman Khondker <salmankhondker1998@gmail.com> Co-authored-by: Copybara-Service <copybara-worker@google.com> Co-authored-by: Mark McDonald <macd@google.com> Co-authored-by: Mark Daoust <markdaoust@google.com> Co-authored-by: Shilpa Kancharla <snkancharla@google.com> Co-authored-by: A. Unique TensorFlower <gardener@tensorflow.org> Co-authored-by: Abhigya Dufare <76903966+abhigyadufare@users.noreply.github.com> Co-authored-by: Ka Long <ka.ko@kennedy.ox.ac.uk> Co-authored-by: Kanglan Tang <kanglan@google.com> Co-authored-by: Michael Hudgins <michaelhudgins@google.com> Co-authored-by: David Huntsperger <dhuntsperger@google.com> Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com> Co-authored-by: Mohamed Aymane Farhi <mfarhi@student.1337.ma> Co-authored-by: Kent McHenry <kentmchenry@gmail.com> Co-authored-by: Tobias Jülg <tobias@juelg.net> Co-authored-by: Aman Prakash <117789470+gitgoap@users.noreply.github.com> Co-authored-by: Vijayasarathi Balasubramanian <vijayasarathib@gmail.com> Co-authored-by: chunduriv <74177924+chunduriv@users.noreply.github.com> Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com> Co-authored-by: YangWu1227 <yangwu2020@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the suggestion in the comment above is used as-is, the runtime returns an error due to incompatible data types.