Skip to content

Conversation

chunduriv
Copy link
Contributor

Update cuDNN and CUDA details to support latest tensorflow version (2.12).

Working Gist:
https://colab.sandbox.google.com/gist/chunduriv/faf217520a36296d07729a25b69d48ea/simple_audio.ipynb#scrollTo=AJs7HHFmg1M9

@chunduriv chunduriv requested a review from a team as a code owner July 4, 2023 11:47
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin patch-18

8bitmp3
8bitmp3 previously approved these changes Jul 6, 2023
@github-actions github-actions bot added the lgtm Community-added approval label Jul 6, 2023
@8bitmp3 8bitmp3 added the ready to pull Start merge process label Jul 6, 2023
@MarkDaoust
Copy link
Member

Do we know why this line is here at all? can we just delete it?

@@ -99,7 +99,7 @@
"outputs": [],
"source": [
"!pip install -U -q tensorflow tensorflow_datasets\n",
"!apt install --allow-change-held-packages libcudnn8=8.1.0.77-1+cuda11.2"
"!apt install --allow-change-held-packages libcudnn8=8.6.0.163-1+cuda11.8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"!apt install --allow-change-held-packages libcudnn8=8.6.0.163-1+cuda11.8"

@MarkDaoust
Ran the notebook with GPU enabled without this line. Let's remove it.

And thank you @chunduriv

8bitmp3
8bitmp3 previously approved these changes Jul 13, 2023
@8bitmp3 8bitmp3 added ready to pull Start merge process and removed ready to pull Start merge process labels Jul 13, 2023
@copybara-service copybara-service bot merged commit 901d32c into tensorflow:master Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Community-added approval ready to pull Start merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants