-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javadoc framework fixes #250
base: master
Are you sure you want to change the base?
Conversation
Sync with master tensorflow on upstream
Merge main branch to local branch
Update after losses merge
Fix Javadoc errors (tensorflow#152)
pull type def
Metrics Phase 1 (tensorflow#180)
Pull latest tensorflow master
Merge with latest
Resync with origin/master
Sync with tensorflow/java master
Fix Javadoc in Constraint
Looks like you're still getting build issues because the core docs aren't built. I've said this elsewhere, but imo the best solution for now is to enable ignoring javadoc failures in framework (like core) until we can update the markdown converter. |
FYI I have the Java version of the markdown converter done. I just need to wire it into the op generator when that is done. |
Should we temporarily turn off doclint on the core docs? https://blog.joda.org/2014/02/turning-off-doclint-in-jdk-8-javadoc.html |
One thing I really don't understand is why we cannot reproduce this error locally? Running a |
I'm relaunching the initial workflow for deploying a first 0.4.0-SNAPSHOT to Sonatype, looks like it was kind of "hanging" there without being completed. I have no clue if that can fix anything but such obscure days, anything is possible... |
I have had some issues on rebuilding locally ( |
OK @JimClarke5 I did a clean but only in the |
Make sure you don't have a Also, are we even publishing javadocs for core-api? I don't see any artifacts in https://oss.sonatype.org/content/repositories/snapshots/org/tensorflow/tensorflow-core-api/0.4.0-SNAPSHOT/ for them (there are for 0.3.0-SNAPSHOT though). And https://oss.sonatype.org/content/repositories/snapshots/org/tensorflow/tensorflow-framework/0.4.0-SNAPSHOT/ is empty, although I suppose that could be because you restarted the action. |
This PR cleans up the JavaDoc in the
org.tensorflow.framework.data
package. Many classes and methods had JavaDoc missing and this was causing errors during the javadoc build phase. As a few classes were missing JavaDoc all together, please double-check that my JavaDoc is accurate.Also, fixed a missing
@param <T>
error in theorg.tensorflow.framework.constraint.Constraint
classNo code was changed in the PR, just JavaDoc addition and fixes.