Skip to content

Conversation

MarkDaoust
Copy link
Member

ndarray is not part of the repo anymore.
This is preventing me from updating the docs to v0.4.

We need to either remove it here or add code to this script to clone that repo and copy-in the code.

`ndarray` is not part of the repo anymore. 
This is preventing me from updating the docs to v0.4.

We need to either remove it here or add code to this script to clone that repo and copy-in the code.
@Craigacp
Copy link
Collaborator

I think we should clone that repo and merge it in. We want the ndarray docs to be in the main docs as otherwise a bunch of the Javadoc will be dead links (and rather confusing to read at that).

@karllessard
Copy link
Collaborator

@MarkDaoust , NdArray have been moved here: https://github.com/tensorflow/java-ndarray

They can both be released independently now (e.g. we've just released 0.4.0 of TF Java but NdArray is still at 0.3.3, which is fine). How can we can keep all this in sync on the website?

@MarkDaoust
Copy link
Member Author

They can both be released independently now (e.g. we've just released 0.4.0 of TF Java but NdArray is still at 0.3.3, which is fine). How can we can keep all this in sync on the website?

I'm not exactly sure yet 😅.

IDK anything about java package management. Do you know a good command I can use to check maven for the latest version of the two packages? If I can automate the version number check I could download the correct branch for both, splice the source together, and generate the docs.

@karllessard
Copy link
Collaborator

IDK anything about java package management. Do you know a good command I can use to check maven for the latest version of the two packages? If I can automate the version number check I could download the correct branch for both, splice the source together, and generate the docs.

But wait... thinking of it, TensorFlow speaking, we want to show on tensorflow.org probably the documentation of the NdArray version that is actually used by the Java client and not necessarily the latest one.

mvn dependency:tree | grep ndarray can give you that version. You can then clone the whole NdArray repo and checkout that version using Git. For example, if the first command gives you the following output:

[INFO] +- org.tensorflow:ndarray:jar:0.3.3:compile
[INFO] |  \- org.tensorflow:ndarray:jar:0.3.3:compile
[INFO] |  \- org.tensorflow:ndarray:jar:0.3.3:compile

You can checkout that version of NdArray git checkout tags/v0.3.3 -b branch. Would that work for you?

@Craigacp
Copy link
Collaborator

We've updated the script to clone the java-ndarray repo as part of the 1.0 release.

@Craigacp Craigacp closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants