-
Notifications
You must be signed in to change notification settings - Fork 214
Fixes Windows build #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Windows build #484
Conversation
I'll merge this out right now as it fixes a broken build. About the Here's some traces:
The generated JNI code:
Also, this binding seems to receive a special treatment from our end: Line 391 in 455fc73
|
I'm guessing TF_OperationName() returns an invalid pointer for some reason... |
Windows build is broken since upgrading to TF2.10.1, the Windows TF build of
libtensorflow_cc
is broken itself, this adds a patch that solves the issue.One problem remains with the
CustomGradientTest
though, which is only failing on Windows. The JNI code generated by JavaCPP crashes the JVM, so I've temporarily disable it (which also means that custom gradient creation is not supported in Windows until we find a fix for that).