-
Notifications
You must be signed in to change notification settings - Fork 655
Any number of channels #179
Any number of channels #179
Conversation
Check out this pull request on ReviewNB: https://app.reviewnb.com/tensorflow/lucid/pull/179 You'll be able to see visual diffs and write comments on notebook cells. Powered by ReviewNB. |
Pull Request Test Coverage Report for Build 534
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you for adding support for this. :)
lucid/optvis/param/color.py
Outdated
else: | ||
return constrain_L_inf(2*t-1)/2 + 0.5 | ||
|
||
def arbitrary_channels_to_rgb(*args, channels=None, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand when I'd use this function in practice. Is it just for the tests? Maybe add a comment. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes exactly :) It's a funky parametrization to test more than 3 channels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! Consider adding a brief comment, or even moving into the tests? Otherwise, LGTM!
@colah It's done :) I have moved the |
Nice! Thanks for the PR. :) |
Modified the image parametrization to accept any number of channels.
The following choices were made :
On top of the main channels modification, there is a commit to fix a bug switching width and height.