Skip to content
This repository was archived by the owner on Apr 10, 2024. It is now read-only.

Conversation

michaelpetrov
Copy link
Contributor

Super long cache filenames (255+ chars) will fail on Mac OS, this applies a hash to those names so they can still be cached. Also this moves the lucid cache into a subfolder for easier size counting / cleanup.

@michaelpetrov michaelpetrov requested a review from colah October 16, 2019 19:05
@coveralls
Copy link

coveralls commented Oct 16, 2019

Pull Request Test Coverage Report for Build 643

  • 13 of 17 (76.47%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 70.741%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lucid/misc/io/reading.py 13 17 76.47%
Totals Coverage Status
Change from base Build 636: -0.03%
Covered Lines: 1939
Relevant Lines: 2741

💛 - Coveralls

Copy link
Contributor

@colah colah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in person. :)

@michaelpetrov michaelpetrov merged commit 2b99f25 into master Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants