Skip to content
This repository was archived by the owner on Apr 10, 2024. It is now read-only.

Conversation

math-and-data
Copy link

Need int64 as default.
See #53

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@coveralls
Copy link

coveralls commented Apr 21, 2018

Pull Request Test Coverage Report for Build 92

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.221%

Totals Coverage Status
Change from base Build 88: 0.0%
Covered Lines: 832
Relevant Lines: 1359

💛 - Coveralls

@googlebot
Copy link

CLAs look good, thanks!

@math-and-data
Copy link
Author

Great, I'm going to close this out (used uuids instead).

@ludwigschubert
Copy link
Contributor

Jupp! Thanks for bringing it up, and sorry we couldn’t go with your PR—I feel UUIDs are a better match for guaranteeing unique names.

@math-and-data
Copy link
Author

No problem - mine was really just a local quick fix. Yours is definitely the more elegant solution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants