This repository was archived by the owner on Apr 23, 2021. It is now read-only.
[spirv] Add bit ops #215
Closed
[spirv] Add bit ops #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiagainst
suggested changes
Nov 1, 2019
lib/Dialect/SPIRV/SPIRVOps.cpp
Outdated
| } | ||
|
|
||
| static LogicalResult verifyShiftOp(Operation *op) { | ||
| return success(op->getOperand(0)->getType() == op->getResult(0)->getType()); |
There was a problem hiding this comment.
Print an error message on failure and also add a test for this? :)
There was a problem hiding this comment.
@antiagainst oh, sorry, I forgot about an error message;
by the way, it seems like an error could be generated only when manually creating this op with builder, not from parser, because while parsing it reuses baseType https://github.com/tensorflow/mlir/pull/215/files#diff-1a7b8ff4af6a0a814aa170d35a45ba8bR465
please fix me if I'm wrong.
Thanks.
There was a problem hiding this comment.
Yes you are right. Please add a test with the generic assembly form. Thanks! :)
There was a problem hiding this comment.
@antiagainst thanks for mention generic assembly form! I didn't know about it.
antiagainst
reviewed
Nov 1, 2019
lib/Dialect/SPIRV/SPIRVOps.cpp
Outdated
| @@ -474,7 +474,13 @@ static void printShiftOp(Operation *op, OpAsmPrinter &printer) { | |||
| } | |||
|
|
|||
| static LogicalResult verifyShiftOp(Operation *op) { | |||
| return success(op->getOperand(0)->getType() == op->getResult(0)->getType()); | |||
| if (op->getOperand(0)->getType() != op->getResult(0)->getType()) { | |||
| return op->emitError("expected the same types for the first operand and " | |||
lib/Dialect/SPIRV/SPIRVOps.cpp
Outdated
| if (op->getOperand(0)->getType() != op->getResult(0)->getType()) { | ||
| return op->emitError("expected the same types for the first operand and " | ||
| "result, but provided ") | ||
| << op->getOperand(0)->getType() << ", " |
antiagainst
approved these changes
Nov 1, 2019
denis0x0D
force-pushed
the
sandbox/bit_ops
branch
from
2d1aa72 to
d9b0852
Compare
This CL added op definitions for a few bit operations: * OpShiftLeftLogical * OpShiftRightArithmetic * OpShiftRightLogical * OpBitCount * OpBitReverse * OpNot Also moved the definition of spv.BitwiseAnd to follow the lexicographical order.
|
Bots failure unrelated this this and should be fixed by 7992732. |
tensorflow-copybara
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 8, 2019
This CL added op definitions for a few bit operations: * OpShiftLeftLogical * OpShiftRightArithmetic * OpShiftRightLogical * OpBitCount * OpBitReverse * OpNot Also moved the definition of spv.BitwiseAnd to follow the lexicographical order. Closes #215 COPYBARA_INTEGRATE_REVIEW=tensorflow/mlir#215 from denis0x0D:sandbox/bit_ops d9b0852b689ac6c4879a9740b1740a2357f44d24 PiperOrigin-RevId: 279350470 Change-Id: I1697efe42bdeeefe43d140af41279aca7b2c48f8
swift-ci
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Dec 24, 2019
This CL added op definitions for a few bit operations: * OpShiftLeftLogical * OpShiftRightArithmetic * OpShiftRightLogical * OpBitCount * OpBitReverse * OpNot Also moved the definition of spv.BitwiseAnd to follow the lexicographical order. Closes tensorflow/mlir#215 COPYBARA_INTEGRATE_REVIEW=tensorflow/mlir#215 from denis0x0D:sandbox/bit_ops d9b0852b689ac6c4879a9740b1740a2357f44d24 PiperOrigin-RevId: 279350470
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL added op definitions for a few bit operations:
Also moved the definition of spv.BitwiseAnd to follow the
lexicographical order.
@antiagainst @MaheshRavishankar can you please take a look? Thanks!