Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Add testing workflow and update contributing guide #259

Merged
merged 2 commits into from
Dec 26, 2022
Merged

Add testing workflow and update contributing guide #259

merged 2 commits into from
Dec 26, 2022

Conversation

codesue
Copy link
Contributor

@codesue codesue commented Dec 24, 2022

What does this pull request do?

  • Adds a basic workflow to run all unit tests on push or pull requests to master and release branches
  • Updates contributing guide to include ways to contribute and instructions on contributing code
  • Sets the min Python version to 3.7

Fixes #239

How did you test this change?

Successful workflow run on my branch: https://github.com/codesue/model-card-toolkit/actions/runs/3767521726

How did you document this change?

Updated the contributing guide

Before submitting

Before submitting a pull request, please be sure to do the following:

  • Read the How to Contribute guide if this is your first contribution.
  • Open an issue or discussion topic to discuss this change.
  • Write new tests if applicable.
  • Update documentation if applicable.

@codesue codesue marked this pull request as ready for review December 24, 2022 05:11
casassg
casassg approved these changes Dec 25, 2022
View reviewed changes
Copy link
Member

@casassg casassg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor issue - happy holidays 😄

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@codesue codesue merged commit 99f3032 into tensorflow:master Dec 26, 2022
@codesue codesue deleted the codesue/testing-ci branch December 26, 2022 02:44
@codesue
Copy link
Contributor Author

codesue commented Dec 26, 2022

minor issue - happy holidays 😄

Happy holidays! 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@casassg casassg casassg approved these changes

@deutranium deutranium Awaiting requested review from deutranium

@hanneshapke hanneshapke Awaiting requested review from hanneshapke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up testing pre-commit hook
2 participants
@codesue @casassg