Recommend the usage of virtual environments in the TensorFlow Model Optimization installation guide #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanchiao
reviewed
May 21, 2020
|
|
||
| ### Stable Builds | ||
|
|
||
| It is recommended to create a Python virtual environment before proceeding to |
There was a problem hiding this comment.
Could you move this above the ### Stable Builds header?
This comment is applicable to both Stable Builds and Installing from Source?
Afterwards, squash the commits and we can merge the PR. Thanks for the PR.
There was a problem hiding this comment.
Effectively it's applicable to both. I made the modification, thanks.
…ptimization installation guide.
Tessil
force-pushed
the
toupstream/mot-install-add-virtual-env-note
branch
from
60ef9d0 to
8ade345
Compare
alanchiao
approved these changes
May 21, 2020
alanchiao
added
the
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds a note in the TensorFlow Model Optimization installation guide to recommend the usage of Python virtual environments in a way similar to the recommendation in the TensorFlow installation guide.