-
Notifications
You must be signed in to change notification settings - Fork 332
Fix TFMOT failure #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TFMOT failure #533
Conversation
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alanchiao,
as mentioned by Anton above this PR seems to contain changes of #508 before it was rebased onto #516 yesterday, i.e. it seems to be outdated. Also there are some changes to jupyter notebooks (unrelated to #508) included in this PR that seem to revert the changes from #512 among other things.
Could you please have a look and either just rebase this PR onto master or resolve it in some other fashion?
Thanks Anton and Benjamin. I'm taking a look into what happened in the PR merging system that caused this issue to happen and try have #508 properly merged. |
@yashk2810 (author of this PR) for visibility on my comment |
Hi @akarmi, is it urgent? sorry that I might not be able to review it very soon. I’ve been feeling unwell since the beginning of my holiday. However, will def take a look when I feel better. |
Don't worry about this Ruomei. I believe Alan is looking at the underlying issue on his side. I don't think anything is needed from us atm. Get better soon! |
Thanks! |
Fix TFMOT failure
FUTURE_COPYBARA_INTEGRATE_REVIEW=#508 from benkli01:toupstream/clustering-visualization 5d75774