Skip to content

[Clustering] Small tidy up - removed unusued variables #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2020
Merged

[Clustering] Small tidy up - removed unusued variables #557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tensorflow_model_optimization/python/core/clustering/keras/cluster_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,11 +326,11 @@ def trainable(self, value):

@property
def trainable_weights(self):
return self.layer.trainable_weights + self._trainable_weights
Copy link

@alanchiao alanchiao Sep 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I've misunderstood but self._trainable_weights and self._non_trainable_weights should be updated automatically during calls to self.add_weight().

By removing "self._trainable_weights" here, someone calling layer.trainable_weights will no longer see all the weights that your wrapper is adding, which breaks the interface.

You can try creating a unit test that checks what layer.trainable_weights outputs and see if it makes sense and look at the base tf.keras.layers.Layer implementation to see what it does.

return self.layer.trainable_weights

@property
def non_trainable_weights(self):
return self.layer.non_trainable_weights + self._non_trainable_weights
return self.layer.non_trainable_weights

@property
def updates(self):
Expand Down