Change key of type 'tuple' to 'str' #1593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dictionary having both 'tuple' and 'str' keys cannot be 'sorted'
This was referenced Jun 21, 2017
|
LGTM |
jch1
reviewed
Jun 26, 2017
There was a problem hiding this comment.
Thanks @justanhduc !
Can you define '_runtime_shapes' as a a constant somewhere and refer to that instead? And use len() instead of hardcoding the -15.
dictionary having both 'tuple' and 'str' keys cannot be 'sorted'
|
@jch1 I updated the PR according to your comment. Please have a look! |
|
@justanhduc could you resolve the remaining merge conflicts? |
|
@derekjchow I resolved all the conflicts. |
|
Thanks for the PR Justan! |
Smellly
pushed a commit
to Smellly/models
that referenced
this pull request
Aug 14, 2017
Change key of type 'tuple' to 'str'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dictionary having both 'tuple' and 'str' keys cannot be 'sorted'