Skip to content

Conversation

gyang274
Copy link
Contributor

@gyang274 gyang274 commented Nov 1, 2017

There are several py_library(), py_binary() and py_test() claimed deps on "//tensorflow" explicitly. This causes the BUILD failed. This is discussed in the issue submitted earlier at tensorflow/models 2571.

As my understanding, the deps = [ "//tensorflow" ] is looking for a directory tensorflow under the slim, which doesn't exist. Remove the deps fixed the issue, as long as the tensorflow is built and available.

Another approach might define the tensorflow library in workspace, by linking it to outside github repo? However, in this way, it could lead to replicated tensorflow modules?

Thank you.

@tensorflow-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@gyang274 gyang274 requested a review from sguada as a code owner November 1, 2017 15:25
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@gyang274
Copy link
Contributor Author

gyang274 commented Nov 1, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Nov 1, 2017
@sguada
Copy link
Member

sguada commented Nov 11, 2017

Fixes #2571

@sguada sguada merged commit d07447a into tensorflow:master Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants