comment out deps on "//tensorflow" #2680
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several py_library(), py_binary() and py_test() claimed deps on "//tensorflow" explicitly. This causes the BUILD failed. This is discussed in the issue submitted earlier at tensorflow/models 2571.
As my understanding, the
deps = [ "//tensorflow" ]
is looking for a directory tensorflow under the slim, which doesn't exist. Remove the deps fixed the issue, as long as the tensorflow is built and available.Another approach might define the tensorflow library in workspace, by linking it to outside github repo? However, in this way, it could lead to replicated tensorflow modules?
Thank you.