Skip to content

Fix Dockerfile build #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2017
Merged

Fix Dockerfile build #2723

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
452fa40
Fix Dockerfile build
Nov 7, 2017
7800075
Fix configure path
Nov 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions research/syntaxnet/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@ RUN mkdir -p $SYNTAXNETDIR \
libgraphviz-dev \
liblapack-dev \
libopenblas-dev \
libpng12-dev \
libpng-dev \
libxft-dev \
patch \
python-dev \
python-mock \
python-pip \
Expand Down Expand Up @@ -55,20 +56,22 @@ RUN python -m pip install \
&& rm -rf /root/.cache/pip /tmp/pip*

# Installs the latest version of Bazel.
RUN wget --quiet https://github.com/bazelbuild/bazel/releases/download/0.4.3/bazel-0.4.3-installer-linux-x86_64.sh \
&& chmod +x bazel-0.4.3-installer-linux-x86_64.sh \
&& ./bazel-0.4.3-installer-linux-x86_64.sh \
&& rm ./bazel-0.4.3-installer-linux-x86_64.sh
RUN wget --quiet https://github.com/bazelbuild/bazel/releases/download/0.5.4/bazel-0.5.4-installer-linux-x86_64.sh \
&& chmod +x bazel-0.5.4-installer-linux-x86_64.sh \
&& ./bazel-0.5.4-installer-linux-x86_64.sh \
&& rm ./bazel-0.5.4-installer-linux-x86_64.sh

COPY WORKSPACE $SYNTAXNETDIR/syntaxnet/WORKSPACE
COPY tools/bazel.rc $SYNTAXNETDIR/syntaxnet/tools/bazel.rc
COPY tensorflow $SYNTAXNETDIR/syntaxnet/tensorflow

# Workaround solving the PYTHON_BIN_PATH not found problem
ENV PYTHON_BIN_PATH=/usr/bin/python
# Compile common TensorFlow targets, which don't depend on DRAGNN / SyntaxNet
# source. This makes it more convenient to re-compile DRAGNN / SyntaxNet for
# development (though not as convenient as the docker-devel scripts).
RUN cd $SYNTAXNETDIR/syntaxnet/tensorflow \
&& tensorflow/tools/ci_build/builds/configured CPU \
&& ./configure CPU \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a typo?
./configure does not really take "CPU" as a command-line argument.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true. I can do another PR if you wish to fix that. It's working properly with it but it is kind of misleading the user.

&& cd $SYNTAXNETDIR/syntaxnet \
&& bazel build -c opt @org_tensorflow//tensorflow:tensorflow_py

Expand Down