Skip to content

assert fails on requesting gpus when not available #3141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 24, 2018
Merged

assert fails on requesting gpus when not available #3141

merged 3 commits into from
Jan 24, 2018

Conversation

yaroslavvb
Copy link
Contributor

@yaroslavvb yaroslavvb requested a review from shlens as a code owner January 10, 2018 18:53
@tensorflow-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@nealwu nealwu requested a review from sherrym as a code owner January 24, 2018 00:48
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@nealwu
Copy link
Contributor

nealwu commented Jan 24, 2018

@protoget could you review and then merge?

@nealwu nealwu added cla: yes and removed cla: no labels Jan 24, 2018
@tfboyd tfboyd self-assigned this Jan 24, 2018
tfboyd
tfboyd approved these changes Jan 24, 2018
View reviewed changes
Copy link
Member

@tfboyd tfboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition.

@tfboyd tfboyd removed request for protoget and sherrym January 24, 2018 18:12
@tfboyd
Copy link
Member

tfboyd commented Jan 24, 2018

Jenkins, test this please.

1 similar comment
@tfboyd
Copy link
Member

tfboyd commented Jan 24, 2018

Jenkins, test this please.

@tfboyd tfboyd merged commit 1f34fca into tensorflow:master Jan 24, 2018
Adrrei pushed a commit to Adrrei/models that referenced this pull request Dec 16, 2018
@tfboyd
Merge pull request tensorflow#3141 from yaroslavvb/patch-1
bb13a0d 
assert fails on requesting gpus when not available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfboyd tfboyd tfboyd approved these changes

+1 more reviewer

@shlens shlens shlens approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@tfboyd tfboyd

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yaroslavvb @tensorflow-jenkins @googlebot @nealwu @tfboyd @shlens