Skip to content

Image encoder: fix binary files parsed as UTF-8 #3712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2018
Merged

Image encoder: fix binary files parsed as UTF-8 #3712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d854dd
Read image data as binary
rzumer Mar 23, 2018
b6866ca
Read code file data as binary
rzumer Mar 23, 2018
a305455
MS-SSIM: Read image data as binary
rzumer Mar 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion research/compression/image_encoder/decoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def main(_):
return

contents = ''
with tf.gfile.FastGFile(FLAGS.input_codes, 'r') as code_file:
with tf.gfile.FastGFile(FLAGS.input_codes, 'rb') as code_file:
contents = code_file.read()
loaded_codes = np.load(io.BytesIO(contents))
assert ['codes', 'shape'] not in loaded_codes.files
Expand Down
2 changes: 1 addition & 1 deletion research/compression/image_encoder/encoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def main(_):
print('\n--iteration must be between 0 and 15 inclusive.\n')
return

with tf.gfile.FastGFile(FLAGS.input_image) as input_image:
with tf.gfile.FastGFile(FLAGS.input_image, 'rb') as input_image:
input_image_str = input_image.read()

with tf.Graph().as_default() as graph:
Expand Down
4 changes: 2 additions & 2 deletions research/compression/image_encoder/msssim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,9 @@ def main(_):
return

with tf.gfile.FastGFile(FLAGS.original_image) as image_file:
img1_str = image_file.read()
img1_str = image_file.read('rb')
with tf.gfile.FastGFile(FLAGS.compared_image) as image_file:
img2_str = image_file.read()
img2_str = image_file.read('rb')

input_img = tf.placeholder(tf.string)
decoded_image = tf.expand_dims(tf.image.decode_png(input_img, channels=3), 0)
Expand Down