Add requirements.txt to official. #3760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmel
approved these changes
Mar 27, 2018
| packages need be installed. Run the following commands for dependency packages: | ||
| > pip install --upgrade py-cpuinfo | ||
| > pip install --upgrade psutil | ||
| packages need be installed. See README for details. |
There was a problem hiding this comment.
No reason to make comments less explicit here.
| @@ -0,0 +1,2 @@ | |||
| psutil>=5.4.3 | |||
| py-cpuinfo>=3.3.0 No newline at end of file | |||
There was a problem hiding this comment.
Should tf-nightly be listed here too? I don't know if there's a way to do a conditional on gpu.
|
P.S. I assume you tested that this works, as I did not. |
|
Yes. Knowing me that is a perfectly reasonable question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have dependencies beyond what TensorFlow already pulls in, we may as well put a bit of formalism to help people out.