Skip to content

Conversation

walkerlala
Copy link
Contributor

when setting --also_save_raw_predictions=True, a file-not-found error is report because we are saving into the --vis_logdir using the fullpath of that image.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@walkerlala
Copy link
Contributor Author

walkerlala commented Mar 27, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@YknZhu
Copy link
Collaborator

YknZhu commented Mar 27, 2018

Thanks! A more proper fix would be using the absolute path in dataset generation process?

@walkerlala
Copy link
Contributor Author

@YknZhu The problem is we are saving into the --vis_logdir using the fullpath of that image. For example if --vis_logdir is /home/someuser/vislog and the path of image is /home/someuser/evaldata/image1.jpg, and then when --also_save_raw_predictions=True, we are saving the result into /home/someuser/vislog/home/someuser/evaldata/image1.jpg, which will raise a file-not-found error.

Copy link
Collaborator

@YknZhu YknZhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Good catch!

@YknZhu YknZhu merged commit 46377f8 into tensorflow:master Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants