Update the importing logic for cpuinfo and psutil. #3781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those two libs are usually not installed by default, and we should not force people to install them if they just want to run resnet.
karmel
approved these changes
Mar 27, 2018
| # Note: cpuinfo is not installed in the TensorFlow OSS tree. | ||
| # It is installable via pip. | ||
| import cpuinfo | ||
|
|
There was a problem hiding this comment.
You will probably need a # pylint: disable=g-import-not-at-top to make glint clear these.
official/utils/logging/logger.py
Outdated
|
|
||
| # Note: cpuinfo is not installed in the TensorFlow OSS tree. | ||
| # It is installable via pip. | ||
| import cpuinfo |
There was a problem hiding this comment.
You will probably need a # pylint: disable=g-import-not-at-top to make glint clear these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those two libs are usually not installed by default, and we should
not force people to install them if they just want to run resnet.