-
Notifications
You must be signed in to change notification settings - Fork 45.5k
Add testing script for local lint and python test. #3797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
#!/bin/bash | ||
|
||
# Presubmit script that run tests and lint under local environment. | ||
# Make sure that tensorflow and pylint is installed. | ||
# usage: models >: ./official/utils/testing/scripts/presubmit.sh | ||
# usage: models >: ./official/utils/testing/scripts/presubmit.sh lint py2_test py3_test | ||
set +x | ||
|
||
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
cd "$SCRIPT_DIR/../../../.." | ||
MODEL_ROOT="$(pwd)" | ||
|
||
export PYTHONPATH="$PYTHONPATH:${MODEL_ROOT}" | ||
|
||
cd official | ||
|
||
lint() { | ||
local exit_code=0 | ||
|
||
RC_FILE="utils/testing/pylint.rcfile" | ||
|
||
echo "===========Running lint test============" | ||
for file in `find . -name '*.py' ! -name '*test.py' -print` | ||
do | ||
echo "Linting ${file}" | ||
pylint --rcfile="${RC_FILE}" "${file}" || exit_code=$? | ||
done | ||
|
||
# More lenient for test files. | ||
for file in `find . -name '*test.py' -print` | ||
do | ||
echo "Linting ${file}" | ||
pylint --rcfile="${RC_FILE}" --disable=missing-docstring,protected-access "${file}" || exit_code=$? | ||
done | ||
|
||
return "${exit_code}" | ||
} | ||
|
||
py_test() { | ||
local PY_BINARY="$1" | ||
local exit_code=0 | ||
|
||
echo "===========Running Python test============" | ||
|
||
for test_file in `find . -name '*test.py' -print` | ||
do | ||
echo "Testing ${test_file}" | ||
${PY_BINARY} "${test_file}" || exit_code=$? | ||
done | ||
|
||
return "${exit_code}" | ||
} | ||
|
||
py2_test() { | ||
local PY_BINARY=$(which python2) | ||
return $(py_test "${PY_BINARY}") | ||
} | ||
|
||
py3_test() { | ||
local PY_BINARY=$(which python3) | ||
return $(py_test "${PY_BINARY}") | ||
} | ||
|
||
test_result=0 | ||
|
||
if [ "$#" -eq 0 ]; then | ||
TESTS="lint py2_test py3_test" | ||
else | ||
TESTS="$@" | ||
fi | ||
|
||
for t in "${TESTS}"; do | ||
${t} || test_result=$? | ||
done | ||
|
||
exit "${test_result}" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to provide a command to run this from anywhere in the repo. For instance:
alias lint_and_test=$(git rev-parse --show-toplevel)/official/utils/testing/scripts/presubmit.sh
Either in the README or in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have usage example on the top of the script.