Add End-to-end tests for wide deep, and fix "wide" and "deep" configurations. #3798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@karmel Ready for review. |
karmel
approved these changes
Mar 29, 2018
official/wide_deep/wide_deep_test.py
Outdated
|
|
||
| # Used for end-to-end tests. | ||
| shutil.copyfile(self.input_csv, os.path.join(self.temp_dir, 'adult.data')) | ||
| shutil.copyfile(self.input_csv, os.path.join(self.temp_dir, 'adult.test')) |
There was a problem hiding this comment.
Seems unusual to write one file and then copy it twice; why not just create the two CSVs above with the desired names, rather than reaching out to shutil?
There was a problem hiding this comment.
I realized I wasn't even using the full test csv. Also, changed to just write rather than shutil.
official/wide_deep/wide_deep.py
Outdated
| def eval_input_fn(): | ||
| return input_fn(test_file, 1, False, flags.batch_size) | ||
|
|
||
| loss_prefix = {'wide': 'linear/', 'deep': 'dnn/'}.get(flags.model_type, '') |
There was a problem hiding this comment.
Maybe make the name dict a module-var, for greater visibility?
omegafragger
pushed a commit
to omegafragger/models
that referenced
this pull request
May 15, 2018
…rations. (tensorflow#3798) * add end-to-end tests for wide_deep delint * address PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already static test data for wide-deep, so I simply used that rather than adding synthetic data.