Skip to content

Conversation

robieta
Copy link
Contributor

@robieta robieta commented Apr 19, 2018

This reverts commit 32aa656.

There is a bad interaction between logging and distribution strategies. Rolling back distribution strategies to keep master in a reasonable state.

@robieta robieta requested review from karmel and qlzh727 April 19, 2018 17:15
@robieta robieta requested a review from a team as a code owner April 19, 2018 17:15
Copy link
Contributor

@karmel karmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review this in detail, as I am assuming it is a strict rollback. Make sure to test that resnet starts, just in case.

@robieta
Copy link
Contributor Author

robieta commented Apr 19, 2018

It is indeed a strict rollback, and I have confirmed that resnet does start.

@robieta robieta merged commit 823da31 into master Apr 19, 2018
@robieta robieta deleted the rollback_resnet_dist branch April 19, 2018 17:33
omegafragger pushed a commit to omegafragger/models that referenced this pull request May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants