Skip to content

Conversation

k-w-w
Copy link
Contributor

@k-w-w k-w-w commented May 2, 2018

Just a direct copy from the working repo - no changes have been made.
edit: Made one edit to update the licensing message. No more edits in this PR!

@k-w-w k-w-w requested a review from karmel May 2, 2018 17:54
@k-w-w k-w-w requested a review from a team as a code owner May 2, 2018 17:54
Copy link
Contributor

@karmel karmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@karmel
Copy link
Contributor

karmel commented May 2, 2018

Ah, linting. I guess you will have to fix the lint errors before it goes in; hopefully they are minimal.

@k-w-w
Copy link
Contributor Author

k-w-w commented May 2, 2018

@karmel the lint tests fails with the description: "Internal CI infrastructure error. Please apply label 'kokoro:force-run' to rerun the build.". The test lints all the files without error. Is it ok to ignore the internal CI build, and merge this PR?

@karmel
Copy link
Contributor

karmel commented May 2, 2018

That kokoro message is just information about how it is configured. Errors are:

************* Module official.transformer.model.beam_search
C:452, 2: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)

************* Module official.transformer.model.transformer
C:316, 2: Missing method docstring (missing-docstring)
C:360, 2: Missing method docstring (missing-docstring)

************* Module official.transformer.model.model_utils
C:111, 0: Trailing newlines (trailing-newlines)

************* Module official.transformer.model.ffn_layer
C: 74, 0: Trailing newlines (trailing-newlines)
C: 39, 2: Missing method docstring (missing-docstring)

@k-w-w
Copy link
Contributor Author

k-w-w commented May 2, 2018

@karmel oooh I see. I've pushed the fix to these lints

@k-w-w k-w-w merged commit 3fca8af into master May 2, 2018
@k-w-w k-w-w deleted the transformer_model branch May 2, 2018 21:31
omegafragger pushed a commit to omegafragger/models that referenced this pull request May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants