Skip to content

Conversation

vladpaunescu
Copy link
Contributor

In current implementation in models/research/object_detection/utils/dataset_util.py at line 137 records_dataset.shuffle(config.shuffle_buffer_size) is not assigned to variable, and it should be records_dataset = records_dataset.shuffle(config.shuffle_buffer_size)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@vladpaunescu
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels May 8, 2018
@vladpaunescu
Copy link
Contributor Author

Can you take a look please? Shuffling is also done in such a way that it doesn't generate random permatation. That is because file dataset is being repeated instead of records inside file. This impacts smaller datasets with no sharding.

Copy link
Contributor

@pkulzc pkulzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants