Add benchmark logger that does stream upload to bigquery. #4209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. All three type of benchmark loggers are behind the control flag: benchmark_logger_type. 2. The benchmark_uploader is spilt into lib and main module. 3. Added test cases with mock for bigquery related classes. Move the benchmark_uploader back to restore the change delta. Readd the benchmark_uploader. Move the benchmark_logger to new location.
|
Hmm, it is hard to review this because of the move; what changed in the moved file? For future reference, there is a git mv that I think helps git track changes a little more clearly. |
karmel
reviewed
May 8, 2018
| "colab": { | ||
| "name": "eager.ipynb", | ||
| "version": "0.3.2", | ||
| "views": {}, |
There was a problem hiding this comment.
Looks like a whole bunch of changes got pulled in... I will hold off reviewing until the changes are resolved, just in case the solution is, "delete this PR and start over."
|
Closing this PR and created new one #4210 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All three type of benchmark loggers are behind the control flag:
benchmark_logger_type.
The benchmark_uploader is spilt into lib and main module.
Added test cases with mock for bigquery related classes.