Skip to content

Update the wide_deep and transformer code for latest benchmark config. #4246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2018
Merged

Update the wide_deep and transformer code for latest benchmark config. #4246

merged 2 commits into from
May 11, 2018

Conversation

qlzh727
Copy link
Member

@qlzh727 qlzh727 commented May 11, 2018

No description provided.

@qlzh727 qlzh727 requested a review from k-w-w May 11, 2018 20:31
@qlzh727 qlzh727 requested review from a team and karmel as code owners May 11, 2018 20:31
@k-w-w
Copy link
Contributor

k-w-w commented May 11, 2018

Can you apply this to transformer_main.py as well?

@qlzh727 qlzh727 changed the title Update the wide_deep code for latest benchmark config. Update the wide_deep and transformer code for latest benchmark config. May 11, 2018
k-w-w
k-w-w approved these changes May 11, 2018
View reviewed changes
Copy link
Contributor

@k-w-w k-w-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@qlzh727 qlzh727 merged commit c0a380d into tensorflow:master May 11, 2018
@qlzh727 qlzh727 deleted the wide_deep_fix branch May 11, 2018 22:05
omegafragger pushed a commit to omegafragger/models that referenced this pull request May 15, 2018
@qlzh727
Update the wide_deep and transformer code for latest benchmark config. (
400b342 
tensorflow#4246)

* Update the wide_deep code for latest benchmark config.

* Also update the transformer benchmark code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@karmel karmel karmel approved these changes

@k-w-w k-w-w k-w-w approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qlzh727 @k-w-w @karmel @googlebot