Update the benchmark run schema with the new columns. #4308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmel
approved these changes
May 18, 2018
| }, | ||
| { | ||
| "description": "The unique name for a test by the combination of key parameters, eg batch size, num of GPU, etc. It is hardware independent.", | ||
| "mode": "NULLABLE", |
There was a problem hiding this comment.
Is this auto-generated or human-set? Presumably a single test_id can have multiple run_ids?
There was a problem hiding this comment.
Actually both. We can set the unique name from commandline if we want. If the value is not set, then our lib can populate the value based on few important hyper param. Will add more comment in the code when we define this flag and lib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the discussion with Toby and existing tf_cnn_benchmark.