Skip to content

resolve 'float' to 'int' conversion, StringIO import, conacat str + byte #4336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2018
Merged

resolve 'float' to 'int' conversion, StringIO import, conacat str + byte #4336

merged 1 commit into from
May 22, 2018

Conversation

j143-zz
Copy link
Contributor

@j143-zz j143-zz commented May 22, 2018

Hi, when running the training script I've encountered.

  1. StringIO import error.
  2. `float' to 'int' conversion error.
  3. concatenating bytes to str.

I tried a fix and successfully trained the model.

Thanks.

@j143-zz j143-zz requested a review from lukaszkaiser as a code owner May 22, 2018 04:02
lukaszkaiser
lukaszkaiser approved these changes May 22, 2018
View reviewed changes
Copy link
Contributor

@lukaszkaiser lukaszkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks, looks all good!

@lukaszkaiser lukaszkaiser merged commit 419bc6e into tensorflow:master May 22, 2018
@j143-zz
Copy link
Contributor Author

j143-zz commented May 23, 2018

Thank you. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lukaszkaiser lukaszkaiser lukaszkaiser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@j143-zz @lukaszkaiser @googlebot @j143