Fix bert_modeling error messages #7616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-mironov
requested review from
guptapriya,
rachellj218 and
saberkun
as code owners
saberkun
previously approved these changes
Oct 1, 2019
saberkun
reviewed
Oct 1, 2019
| """Implements build() for the layer.""" | ||
| dtype = tf.as_dtype(self.dtype or tf.keras.backend.floatx()) | ||
| if not (dtype.is_floating or dtype.is_complex): | ||
| raise TypeError("Unable to build `Dense` layer with non-floating point " |
There was a problem hiding this comment.
Could you help fix just these two lint errors?
official/nlp/bert_modeling.py:651: [C0301(line-too-long), ] Line too long (90/80)
official/nlp/bert_modeling.py:655: [C0301(line-too-long), ] Line too long (81/80)
There was a problem hiding this comment.
Done. I couldn't find pylint script or config, but I hope this particular errors shoud gone now.
sergei-mironov
force-pushed
the
fix-bert-messages
branch
from
7c9cac8 to
da2d13b
Compare
saberkun
added
the
ready to pull
tf-models-copybara-bot
pushed a commit
that referenced
this pull request
Oct 3, 2019
PiperOrigin-RevId: 272700366
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix making error messages look more clear.