Moved check out of the loop to avoid quadratic runtime. #9670
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test that verifies that all label ids are non-negative is not influenced by the loop, so it can be performed once at the beginning. This avoids a quadratic runtime, which has a high impact on execution time for very long sequences.
Type of change
Tests
Checklist
Code owners: @saberkun @chengithuber @lehougoogle @rachellj218 @jaeyounkim
CC: My intern host sundermeyer@google.com and co-host fhartmann@google.com