-
Notifications
You must be signed in to change notification settings - Fork 188
Adding mentions to Denoised Smoothing #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
research/README.md
Outdated
`third_party` directory contains research project contributions from the open source | ||
community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that's the intent of the third_party directory here. @DualityGap, any thoughts on this? My understanding is that this indicates that contributions here are built on top of other third_party implementations (https://github.com/microsoft/denoised-smoothing in this example). So, I'd suggest removing these 2 lines. As another counterexample, the gnn-survey directory was also a community contribution but that was a from-scratch implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. In this case, you are right. I have reused some of the bits from the official implementation (with all the citations) and reimplemented bits that were absolutely necessary to make things work in TensorFlow and Keras. I will reword the phrasing then.
research/README.md
Outdated
|
||
|
||
The implementations of Denoised Smoothing [5] are provided in the | ||
`neural_clustering` folder on a strict "as is" basis, without warranties or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo. Not neural_clustering
but third_party/denoised_smoothing
.
research/README.md
Outdated
|
||
## [Denoised Smoothing: A Provable Defense for Pretrained Classifiers](third_party/denoised_smoothing) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra blank line.
research/README.md
Outdated
|
||
[[5] H. Salman, M.Sun, C. Mitelut, G. Yang, A. Kapoor., Z. Kolter "Denoised Smoothing: | ||
A Provable Defense for Pretrained Classifiers." NeurIPS 2020](https://arxiv.org/abs/2003.01908) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove blank line.
PiperOrigin-RevId: 399526290
No description provided.