fix tensor_shape method for Graph #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! By the way, you don't need to create a new pull request to throw out changes; you can remove unneeded changes from the latest commit by running (For reference, this is an update of #91.) |
|
Thanks for the info, had the impression git resets were hard/impossible to pull out when you have committed to the upstream repo already. Will try it this way next time. Thanks anyway! |
|
@iduartgomez: helpful note, it's the |
ramon-garcia
pushed a commit
to ramon-garcia/tensorflow-rust
that referenced
this pull request
May 20, 2023
…tensorflow#93) * added new row indexer for parquet data frame * updated parquet dataset * support dates (INT64 only) in plain encoding * update readme * some changes to the test * test don't touch Ivan please * reversed the timestamp_millis type using unannotated INT96 as Spark INT64 implementation not complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the tensor_shape method for the Graph type,
.len()was being called to pull the rank information from the tensor when calling C instead of passing the rank information directly , so an error was being returned by the API (ie. InvalidArgument: Expected rank is 0 but actual rank is 2 on a [3, 3] tensor) as the vector was always empty (is an empty vector being passed to C so it can be filled with the dimension information).Fixed it and added a test to check for this in the future.
P.S: made a new clean pull request without all the whitespace changes