Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

add 'Element: Differentiable' constraint to DifferentiableView extensions #538

Merged
merged 1 commit into from
Oct 30, 2019
Merged

add 'Element: Differentiable' constraint to DifferentiableView extensions #538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions Sources/TensorFlow/StdlibExtensions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,9 @@ extension Array: ElementaryFunctions where Element: ElementaryFunctions {

// MARK: - Array derivative extensions

extension Array.DifferentiableView: ElementaryFunctions where Element: ElementaryFunctions {
extension Array.DifferentiableView: ElementaryFunctions
where Element: Differentiable & ElementaryFunctions
{
/// The square root of `x`.
///
/// For real types, if `x` is negative the result is `.nan`. For complex
Expand Down Expand Up @@ -192,7 +194,9 @@ extension Array.DifferentiableView: ElementaryFunctions where Element: Elementar
}

extension Array.DifferentiableView
: MutableCollection, RandomAccessCollection, RangeReplaceableCollection {
: MutableCollection, RandomAccessCollection, RangeReplaceableCollection
where Element: Differentiable
{
public typealias Element = Array<Element>.Element
public typealias Index = Array<Element>.Index
public typealias Indices = Array<Element>.Indices
Expand All @@ -214,7 +218,9 @@ extension Array.DifferentiableView
public init() { self.init(.init()) }
}

extension Array.DifferentiableView: VectorProtocol where Element: VectorProtocol {
extension Array.DifferentiableView: VectorProtocol
where Element: Differentiable & VectorProtocol
{
public typealias VectorSpaceScalar = Element.VectorSpaceScalar

public func adding(_ x: Element.VectorSpaceScalar) -> Array<Element>.DifferentiableView {
Expand Down Expand Up @@ -249,7 +255,8 @@ extension Array.DifferentiableView: VectorProtocol where Element: VectorProtocol
}

extension Array.DifferentiableView: PointwiseMultiplicative
where Element: PointwiseMultiplicative {
where Element: Differentiable & PointwiseMultiplicative
{
// FIXME: `one` should probably be removed from the protocol. `Array` cannot represent `one`.
public static var one: Self {
fatalError("One is not array-representable")
Expand Down