fix: add explicit length check in ShapeEquals #101287
Merged
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HurSungYun
changed the title
HurSungYun
changed the title
mihaimaruseac
approved these changes
Oct 3, 2025
google-ml-butler
bot
added
kokoro:force-run
github-project-automation
bot
moved this from Assigned Reviewer
to Approved by Reviewer
in PR Queue
|
@mihaimaruseac Thank you for the review! Please merge this PR when you have time. |
|
Please consult CONTRIBUTING.md (as one should do always before contributing to a new codebase), there is a process with automatic integration inside the Google codebase and a new review there. We don't merge the PRs via the GitHub button. |
|
Thank you for letting me know. I’ll wait to see the integration completed. Please let me know if there’s anything else I should do. |
github-project-automation
bot
moved this from Approved by Reviewer
to Closed/Rejected
in PR Queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ShapeEquals only compared element-wise dimensions using zip(), which meant that two shapes with the same prefix but different rank could be considered equal like
This patch adds an explicit length check so that rank of the shape must also match.
If anything is incorrect, feel free to close this PR.