Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MklMatMulPrimitiveFactory to support Arm Compute Library backend #52261

Merged
merged 1 commit into from Oct 8, 2021
Merged

Update MklMatMulPrimitiveFactory to support Arm Compute Library backend #52261

merged 1 commit into from Oct 8, 2021

Conversation

cfRod
Copy link
Contributor

@cfRod cfRod commented Oct 5, 2021

Related to issue #47415 and PR #47775. Adding support for caching matmul primitives.
Updates onednn_acl_primitives.patch to include matmul primitives.

@cfRod cfRod requested a review from penpornk as a code owner October 5, 2021 14:22
@google-ml-butler google-ml-butler bot added size:L CL Change Size: Large awaiting review Pull request awaiting review labels Oct 5, 2021
@google-cla google-cla bot added the cla: yes label Oct 5, 2021
@gbaned gbaned self-assigned this Oct 5, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Oct 5, 2021
@gbaned gbaned added the comp:mkl MKL related issues label Oct 5, 2021
penpornk
penpornk requested changes Oct 6, 2021
View reviewed changes
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

tensorflow/core/kernels/mkl/mkl_batch_matmul_op.cc Outdated Show resolved Hide resolved
tensorflow/core/kernels/mkl/mkl_matmul_ops_common.h Outdated Show resolved Hide resolved
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Oct 6, 2021
@penpornk penpornk removed the awaiting review Pull request awaiting review label Oct 6, 2021
@cfRod
Update MklMatMulPrimitiveFactory to support Arm Compute Library backend
6b8ff16 
Related to issue tensorflow#47415 and PR tensorflow#47775. Adding support for caching matmul primitives.
Updates onednn_acl_primitives.patch to include matmul primitives.
penpornk
penpornk approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes! :)

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 7, 2021
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Oct 7, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 7, 2021
@copybara-service copybara-service bot merged commit 1a811e3 into tensorflow:master Oct 8, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Oct 8, 2021
@cfRod
Copy link
Contributor Author

cfRod commented Oct 11, 2021

@penpornk thanks!
If this can be cherry-picked onto 2.7 rls that would be great!

@penpornk penpornk mentioned this pull request Oct 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penpornk penpornk penpornk approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:mkl MKL related issues size:L CL Change Size: Large
Projects
PR Queue
  
Approved by Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cfRod @penpornk @kokoro-team @gbaned