Skip to content

Conversation

cfRod
Copy link
Contributor

@cfRod cfRod commented Oct 5, 2021

Related to issue #47415 and PR #47775. Adding support for caching matmul primitives.
Updates onednn_acl_primitives.patch to include matmul primitives.

@cfRod cfRod requested a review from penpornk as a code owner October 5, 2021 14:22
@google-ml-butler google-ml-butler bot added size:L CL Change Size: Large awaiting review Pull request awaiting review labels Oct 5, 2021
@google-cla google-cla bot added the cla: yes label Oct 5, 2021
@gbaned gbaned self-assigned this Oct 5, 2021
@gbaned gbaned added the comp:mkl MKL related issues label Oct 5, 2021
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@penpornk penpornk removed the awaiting review Pull request awaiting review label Oct 6, 2021
Related to issue tensorflow#47415 and PR tensorflow#47775. Adding support for caching matmul primitives.
Updates onednn_acl_primitives.patch to include matmul primitives.
@cfRod cfRod force-pushed the mkldnn-acl-matmul branch from 0f66cd0 to 6b8ff16 Compare October 7, 2021 09:38
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes! :)

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 7, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 7, 2021
@copybara-service copybara-service bot merged commit 1a811e3 into tensorflow:master Oct 8, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Oct 8, 2021
@cfRod
Copy link
Contributor Author

cfRod commented Oct 11, 2021

@penpornk thanks!
If this can be cherry-picked onto 2.7 rls that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:mkl MKL related issues size:L CL Change Size: Large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants