Replace deprecated "pipes.quote" with "shlex.quote" for ROCm #89799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is basically f6d09e2, but for ROCm. Signed-off-by: Aseem Athale <athaleaseem@gmail.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
mihaimaruseac
approved these changes
Mar 24, 2025
google-ml-butler
bot
added
kokoro:force-run
github-project-automation
bot
moved this from Assigned Reviewer
to Approved by Reviewer
in PR Queue
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Mar 24, 2025
Imported from GitHub PR tensorflow/tensorflow#89799 This is basically f6d09e2, but for ROCm. Quite a minor change, but one I ran across when trying to build the ROCm bits, because the build failed as it tried to import pipes. Copybara import of the project: -- fe2a4036944d0a3d9f9a16a85581a79ddba11775 by Aseem Athale <athaleaseem@gmail.com>: Replace deprecated "pipes.quote" with "shlex.quote" for ROCm This is basically f6d09e2, but for ROCm. Signed-off-by: Aseem Athale <athaleaseem@gmail.com> Merging this change closes #89799 FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#89799 from mistersmee:master fe2a4036944d0a3d9f9a16a85581a79ddba11775 PiperOrigin-RevId: 739931081
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Mar 25, 2025
Imported from GitHub PR tensorflow/tensorflow#89799 This is basically f6d09e2, but for ROCm. Quite a minor change, but one I ran across when trying to build the ROCm bits, because the build failed as it tried to import pipes. Copybara import of the project: -- fe2a4036944d0a3d9f9a16a85581a79ddba11775 by Aseem Athale <athaleaseem@gmail.com>: Replace deprecated "pipes.quote" with "shlex.quote" for ROCm This is basically f6d09e2, but for ROCm. Signed-off-by: Aseem Athale <athaleaseem@gmail.com> Merging this change closes #89799 FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#89799 from mistersmee:master fe2a4036944d0a3d9f9a16a85581a79ddba11775 PiperOrigin-RevId: 739931081
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Mar 25, 2025
Imported from GitHub PR tensorflow/tensorflow#89799 This is basically f6d09e2, but for ROCm. Quite a minor change, but one I ran across when trying to build the ROCm bits, because the build failed as it tried to import pipes. Copybara import of the project: -- fe2a4036944d0a3d9f9a16a85581a79ddba11775 by Aseem Athale <athaleaseem@gmail.com>: Replace deprecated "pipes.quote" with "shlex.quote" for ROCm This is basically f6d09e2, but for ROCm. Signed-off-by: Aseem Athale <athaleaseem@gmail.com> Merging this change closes #89799 PiperOrigin-RevId: 740356497
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
The number of local participants doesn't add new information to the key, because we should never get two identical cliques that only different in the number of local participants. However, putting the number inside the key makes so many places in the codebase simpler and avoids annoying recalculations. We can easily count the number of local devices when we create the key, but later it requires getting runtime param and devices ids again. FUTURE_COPYBARA_INTEGRATE_REVIEW=#89799 from mistersmee:master fe2a403 PiperOrigin-RevId: 739909378
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
Rollback of openxla/xla#24111 Having both with-mkl and no-mkl targets could possibly lead to ODR violation if multiple dependencies in the same target link to both variants. The use cases that don't want to link oneDNN should stick to bazel `--define=tensorflow_mkldnn_contraction_kernel=0` flag instead. Reverts 3651dbd FUTURE_COPYBARA_INTEGRATE_REVIEW=#89799 from mistersmee:master fe2a403 PiperOrigin-RevId: 740324610
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
Updates LLVM usage to match [6c68cc4df1bf](llvm/llvm-project@6c68cc4df1bf) FUTURE_COPYBARA_INTEGRATE_REVIEW=#89799 from mistersmee:master fe2a403 PiperOrigin-RevId: 740359933
github-project-automation
bot
moved this from Approved by Reviewer
to Merged
in PR Queue
charleshofer
pushed a commit
to ROCm/xla
that referenced
this pull request
Apr 3, 2025
Imported from GitHub PR tensorflow/tensorflow#89799 This is basically f6d09e2, but for ROCm. Quite a minor change, but one I ran across when trying to build the ROCm bits, because the build failed as it tried to import pipes. Copybara import of the project: -- fe2a4036944d0a3d9f9a16a85581a79ddba11775 by Aseem Athale <athaleaseem@gmail.com>: Replace deprecated "pipes.quote" with "shlex.quote" for ROCm This is basically f6d09e2, but for ROCm. Signed-off-by: Aseem Athale <athaleaseem@gmail.com> Merging this change closes #89799 PiperOrigin-RevId: 740356497
charleshofer
pushed a commit
to ROCm/xla
that referenced
this pull request
Apr 3, 2025
Imported from GitHub PR tensorflow/tensorflow#89799 This is basically f6d09e2, but for ROCm. Quite a minor change, but one I ran across when trying to build the ROCm bits, because the build failed as it tried to import pipes. Copybara import of the project: -- fe2a4036944d0a3d9f9a16a85581a79ddba11775 by Aseem Athale <athaleaseem@gmail.com>: Replace deprecated "pipes.quote" with "shlex.quote" for ROCm This is basically f6d09e2, but for ROCm. Signed-off-by: Aseem Athale <athaleaseem@gmail.com> Merging this change closes #89799 PiperOrigin-RevId: 740356497
mrodden
pushed a commit
to ROCm/xla
that referenced
this pull request
Apr 3, 2025
Imported from GitHub PR tensorflow/tensorflow#89799 This is basically f6d09e2, but for ROCm. Quite a minor change, but one I ran across when trying to build the ROCm bits, because the build failed as it tried to import pipes. Copybara import of the project: -- fe2a4036944d0a3d9f9a16a85581a79ddba11775 by Aseem Athale <athaleaseem@gmail.com>: Replace deprecated "pipes.quote" with "shlex.quote" for ROCm This is basically f6d09e2, but for ROCm. Signed-off-by: Aseem Athale <athaleaseem@gmail.com> Merging this change closes #89799 PiperOrigin-RevId: 740356497
mrodden
pushed a commit
to ROCm/xla
that referenced
this pull request
Apr 3, 2025
Imported from GitHub PR tensorflow/tensorflow#89799 This is basically f6d09e2, but for ROCm. Quite a minor change, but one I ran across when trying to build the ROCm bits, because the build failed as it tried to import pipes. Copybara import of the project: -- fe2a4036944d0a3d9f9a16a85581a79ddba11775 by Aseem Athale <athaleaseem@gmail.com>: Replace deprecated "pipes.quote" with "shlex.quote" for ROCm This is basically f6d09e2, but for ROCm. Signed-off-by: Aseem Athale <athaleaseem@gmail.com> Merging this change closes #89799 PiperOrigin-RevId: 740356497
charleshofer
pushed a commit
to ROCm/xla
that referenced
this pull request
Apr 3, 2025
Imported from GitHub PR tensorflow/tensorflow#89799 This is basically f6d09e2, but for ROCm. Quite a minor change, but one I ran across when trying to build the ROCm bits, because the build failed as it tried to import pipes. Copybara import of the project: -- fe2a4036944d0a3d9f9a16a85581a79ddba11775 by Aseem Athale <athaleaseem@gmail.com>: Replace deprecated "pipes.quote" with "shlex.quote" for ROCm This is basically f6d09e2, but for ROCm. Signed-off-by: Aseem Athale <athaleaseem@gmail.com> Merging this change closes #89799 PiperOrigin-RevId: 740356497
mrodden
pushed a commit
to ROCm/xla
that referenced
this pull request
Apr 3, 2025
Imported from GitHub PR tensorflow/tensorflow#89799 This is basically f6d09e2, but for ROCm. Quite a minor change, but one I ran across when trying to build the ROCm bits, because the build failed as it tried to import pipes. Copybara import of the project: -- fe2a4036944d0a3d9f9a16a85581a79ddba11775 by Aseem Athale <athaleaseem@gmail.com>: Replace deprecated "pipes.quote" with "shlex.quote" for ROCm This is basically f6d09e2, but for ROCm. Signed-off-by: Aseem Athale <athaleaseem@gmail.com> Merging this change closes #89799 PiperOrigin-RevId: 740356497
alekstheod
pushed a commit
to ROCm/xla
that referenced
this pull request
Apr 11, 2025
Imported from GitHub PR tensorflow/tensorflow#89799 This is basically f6d09e2, but for ROCm. Quite a minor change, but one I ran across when trying to build the ROCm bits, because the build failed as it tried to import pipes. Copybara import of the project: -- fe2a4036944d0a3d9f9a16a85581a79ddba11775 by Aseem Athale <athaleaseem@gmail.com>: Replace deprecated "pipes.quote" with "shlex.quote" for ROCm This is basically f6d09e2, but for ROCm. Signed-off-by: Aseem Athale <athaleaseem@gmail.com> Merging this change closes #89799 PiperOrigin-RevId: 740356497
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically f6d09e2, but for ROCm.
Quite a minor change, but one I ran across when trying to build the ROCm bits, because the build failed as it tried to import pipes.