Support tensors rank 5

[zaidalyafeai]

Added tensors rank 5. This is still a work in progress. The shader_compiler.ts file needs to be further revised ... Many gpu operations needs to be changed like reverse, transpose, slice ...

---

This change is 

[zaidalyafeai]

Does anybody have time to review this? I am traveling in a few days and will not have time to work on the comments.

[dsmilkov]

@zaidalyafeai , this is a great start to adding 5D. Thank you for this change. Since you already modified pad, reverse, transpose and tile to work with 5D in this PR, you'll have to add tests for those ops as well. I only see 5d tests for tile. Let me know once you add those tests and then this will be ready to go.

I'm happy to also review future PRs that change other ops to work with 5D. Thank you!

---

Reviewed 10 of 10 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

src/ops/array_ops.ts, line 263 at r1 (raw file):

   * ```js
   * // Pass a flat array and specify a shape.
   * tf.tensor4d([1, 2, 3, 4, 5, 6], [1, 2, 2, 2, 1]).print();

call tensor5d

---

src/ops/array_ops.ts, line 277 at r1 (raw file):

      dtype: DataType = 'float32'): Tensor5D {
    if (shape != null && shape.length !== 5) {
      throw new Error('tensor5d() requires shape to have four numbers');

fix error message to say five numbers instead of four

---

src/ops/array_ops.ts, line 1008 at r1 (raw file):

      constantValue = 0): Tensor5D {
    util.assert(
        paddings.length === 4 && paddings[0].length === 2 &&

fix these checks to be for 5d (the current values are for the 4d case)

---

Comments from Reviewable

[zaidalyafeai]

@dsmilkov, I will not have the time to add unit tests for reverse, pad and transpose because I am getting ready to travel. Should I revert the changes I made to those operations ( they are minimal) ?

[dsmilkov]

No worries. Reverting those sounds good and then we can continue later with the follow up changes. Safe travels!

[nsthorat]

Let me know when this is ready to look at again.

[zaidalyafeai]

@nsthorat I already commited my final changes.

[nsthorat]

It's looking good! Would be good to add some unit tests for operations with 5D Tensors that aren't just construction, specifically for operations that operate on any rank (mean, unary ops like square, etc).

---

Review status: 5 of 8 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

---

Comments from Reviewable

[zaidalyafeai]

@nsthorat, It is not clear to me what operations should I focus on. The unary ops file only contains unit tests for tensors of rank less than 3.

[rodrigob]

it is not clear to me what operations should I focus on.
why not start with mean and square and see from there ?

[zaidalyafeai]

Since transpose is necessary for tensorflow/tfjs#161 I implemented it . Maybe we can merge this and support the other gpu operations once needed ?

[zaidalyafeai]

@nsthorat @dsmilkov I added unit tests for abs and relu to make sure 5D tensors work fine. Let me know if we need more...

[dsmilkov]

Thank you!! And sorry for the wait

---

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from Reviewable

[dsmilkov]

One unrelated test fails - it's a known test tracked in tensorflow/tfjs#377 which shouldn't block this PR.

[zaidalyafeai]

Awesome 😀 glad it worked.

[zaidalyafeai]

@dsmilkov, time to work on the remaining gpu operations ?