-
Notifications
You must be signed in to change notification settings - Fork 944
adds pull request template #1036
Conversation
Thanks for looking into this. So the PR description isn't actually what matters, it's what we end up putting in the git commit message. Is there a way to set up the template for that instead? |
And to be clear, the PR description doesn't automatically get added to the commit message. |
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
We still need to manually copy the PR desc into the commit message when we squash and merge right? or does this template show up in the squash-and-merge message as well? |
@dsmilkov The user still needs to write their own squash & merge commit message. Unfortunately there does not seem to be a good way to automatically populate the commit message. It would require modifying the |
We still have to copy paste it, but this will at least help us remember. |
I feel we should move templates and contributing file to |
I was thinking if we can automate adding PR title as commit title and PR description as commit description. Turns out there is already a Chrome extension that does it. Sharing it here: https://github.com/sindresorhus/refined-github |
I installed the extension and works great for me (copies the PR title and description into the commit)! |
DEV adds default pull request template to help remind contributors to use PR commit message tags.
This change is