This repository has been archived by the owner on Aug 15, 2019. It is now read-only.
[io] Fix a bug in concatenateTypedArrays #1181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was incorrectly assumed that the
buffer
of aTypedArray
has the samebyteLength
as theTypedArray
itself.The two can actually be different if the
TypedArray
is createdfrom an offset and a length from an
ArrayBuffer
, e.g.,const x = new Float32Array(myBuffer, 32, 4)
.This actually happens during the desrialization of a
tf.Model
.This PR fixes it by checking whether the
byteLength
andbuffer.byteLength
of aTypedArray
are equal, and if not, creatinga new
TypedArray
with the buffer that matches the actualbyteLength
.BUG
This change is