New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviceNotSupported: Improves the message shown to user #214

Merged
merged 2 commits into from Oct 15, 2017

Conversation

Projects
None yet
2 participants
@manrajgrover
Copy link
Contributor

manrajgrover commented Oct 14, 2017

Currently, user is told that device is not supported even if it does. This happens because WebGL is not enabled on user's browser. This pull request fixes this issue and now user is told to enable WebGL if browser is supported.

Fixes #16.


This change is Reviewable

manrajgrover added some commits Oct 14, 2017

@nsthorat

This comment has been minimized.

Copy link
Collaborator

nsthorat commented Oct 15, 2017

:lgtm_strong:

Another great PR!


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@nsthorat

This comment has been minimized.

Copy link
Collaborator

nsthorat commented Oct 15, 2017

Thanks for the contribution :)


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@nsthorat nsthorat merged commit 9b5b1b1 into tensorflow:master Oct 15, 2017

3 checks passed

cla/google All necessary CLAs are signed
code-review/reviewable 1/1 LGTMs
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment