Skip to content
This repository was archived by the owner on Aug 15, 2019. It is now read-only.

Conversation

Lewuathe
Copy link
Contributor

@Lewuathe Lewuathe commented Sep 5, 2017

npm run build creates a build directory in dist. We can add this dir to gitignore.


This change is Reviewable

@nsthorat
Copy link
Contributor

nsthorat commented Sep 5, 2017

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


.gitignore, line 10 at r1 (raw file):

npm-debug.log
.DS_Store
dist

can you make this dist/ just so that it mirrors the style from above (and it's clear it's a dir)


Comments from Reviewable

`npm run build` creates a build directory in `dist`. We can add this dir
to gitignore.
@Lewuathe
Copy link
Contributor Author

Lewuathe commented Sep 6, 2017

@nsthorat Thanks for checking. I updated accordingly.

@nsthorat
Copy link
Contributor

nsthorat commented Sep 6, 2017

:lgtm_strong:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Comments from Reviewable

@nsthorat
Copy link
Contributor

nsthorat commented Sep 6, 2017

Update this branch and then I will merge it (someone added something else to gitignore)!

@nsthorat nsthorat merged commit 0716131 into tensorflow:master Sep 6, 2017
mnottheone pushed a commit to mnottheone/deeplearnjs that referenced this pull request Dec 1, 2018
`npm run build` creates a build directory in `dist`. We can add this dir
to gitignore.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants