Skip to content
This repository was archived by the owner on Aug 15, 2019. It is now read-only.

Conversation

Lewuathe
Copy link
Contributor

@Lewuathe Lewuathe commented Sep 6, 2017

Add benchmark of max pool CPU operation as well as matmul benchmark to compare CPU and GPU.

screen shot 2017-09-06 at 22 50 53


This change is Reviewable

@nsthorat
Copy link
Contributor

nsthorat commented Sep 6, 2017

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


demos/benchmarks/max_pool_cpu_benchmark.ts, line 44 at r1 (raw file):

  const start = performance.now();
  for (let i = 0; i < OP_RUNS; i++) {
		math.maxPool(x as Array3D, fieldSize, stride, zeroPad);

use spaces instead of indents here and everywhere


Comments from Reviewable

@Lewuathe Lewuathe force-pushed the max-pool-cpu-benchmark branch from d4519b8 to 207d682 Compare September 7, 2017 13:11
@Lewuathe
Copy link
Contributor Author

Lewuathe commented Sep 7, 2017

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.


demos/benchmarks/max_pool_cpu_benchmark.ts, line 44 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

use spaces instead of indents here and everywhere

Thanks. I updated.


Comments from Reviewable

@nsthorat
Copy link
Contributor

nsthorat commented Sep 7, 2017

:lgtm_strong:


Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@nsthorat nsthorat merged commit f7a8cf0 into tensorflow:master Sep 7, 2017
mnottheone pushed a commit to mnottheone/deeplearnjs that referenced this pull request Dec 1, 2018
* Comparison max pool benchmark between CPU and GPU
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants