-
Notifications
You must be signed in to change notification settings - Fork 95
Scheme-based Save and Load #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. small comment question
src/engine/training.ts
Outdated
`Cannot find any save handlers for URL '${handlerOrURL}'`); | ||
} else if (handlers.length > 1) { | ||
throw new ValueError( | ||
`Found more then one (${handlers.length}) save handlers for ` + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this should be "than" not "then"
src/model_save_test.ts
Outdated
// Check the equality of the two models' weights. | ||
const weights1 = model1.getWeights(); | ||
const weights2 = model2.getWeights(); | ||
// because the second layer has `useBias: false`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how I should be interpreting this comment
Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed. src/engine/training.ts, line 1706 at r1 (raw file):
lower case o src/engine/training.ts, line 1760 at r1 (raw file):
name "null" here Comments from Reviewable |
add print outs to code snippets
Review status: 0 of 5 files reviewed at latest revision, 4 unresolved discussions, all commit checks successful. src/model_save_test.ts, line 133 at r1 (raw file): Previously, bileschi (Stanley Bileschi) wrote…
Done. This is cruft from an earlier iteration. Removed. Thanks for catching that. src/engine/training.ts, line 1706 at r1 (raw file): Previously, nsthorat (Nikhil Thorat) wrote…
Done. src/engine/training.ts, line 1745 at r1 (raw file): Previously, bileschi (Stanley Bileschi) wrote…
Done. Comments from Reviewable |
Review status: 0 of 5 files reviewed at latest revision, 4 unresolved discussions, all commit checks successful. src/engine/training.ts, line 1760 at r1 (raw file): Previously, nsthorat (Nikhil Thorat) wrote…
Done. Comments from Reviewable |
FEATURE -- Add capability to save and
tf.Model
s using the following mediums: browser local storage, IndexedDB, file downloads and updates and HTTP requests.Towards: tensorflow/tfjs#13
This change is